Ticket #45 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

notify-recipient should be notify-recipient-uri

Reported by: stephane.chazelas Owned by: jerome
Priority: major Milestone: 1.27 final
Component: pkipplib Version: development
Keywords: Cc:

Description

At least with cups-1.3.9 and cups 1.4.0, you need:

Index: pkipplib/pkipplib.py
===================================================================
--- pkipplib/pkipplib.py (revision 3503)
+++ pkipplib/pkipplib.py (working copy)
@@ -789,7 +789,7 @@

if userdata is not None :

req.subscriptionnotify-user-data? = ("octetString-with-an-unspecified-format", userdata)

if recipient is not None :

- req.subscriptionnotify-recipient? = ("uri", recipient)
+ req.subscriptionnotify-recipient-uri? = ("uri", recipient)

if pullmethod is not None :

req.subscriptionnotify-pull-method? = ("keyword", pullmethod)

if charset is not None :

In order to be able to create a subscription.

Attachments

diff (0.7 kB) - added by stephane.chazelas 12 years ago.
Same diff attached.

Change History

Changed 12 years ago by stephane.chazelas

  • attachment diff added

Same diff attached.

Changed 12 years ago by stephane.chazelas

The related change in cups is:


r6380 | mike | 2007-03-21 15:18:53 +0000 (Wed, 21 Mar 2007) | 4 lines

Missed a reference to notify-recipient instead of notify-recipient-uri...

Update test header to show CUPS 1.3...

Index: scheduler/ipp.c
===================================================================
--- scheduler/ipp.c     (revision 6379)
+++ scheduler/ipp.c     (revision 6380)
@@ -1863,7 +1863,7 @@

     while (attr && attr->group_tag != IPP_TAG_ZERO)
     {
-      if (!strcmp(attr->name, "notify-recipient") &&
+      if (!strcmp(attr->name, "notify-recipient-uri") &&
           attr->value_tag == IPP_TAG_URI)
         recipient = attr->values[0].string.text;
       else if (!strcmp(attr->name, "notify-pull-method") &&

So since cups 1.2.11

Changed 12 years ago by jerome

  • status changed from new to assigned
  • component changed from pykota to pkipplib

Changed 12 years ago by jerome

  • status changed from assigned to closed
  • resolution set to fixed

(In [3504]) Used the patch provided by Stephane Chazelas to fix #45.
It's applied unconditionally (CUPS' version is not checked) for several
reasons :
* CUPS 1.2.11 is very old now.
* This part of pkipplib is not used in PyKota at least for now.

Note: See TracTickets for help on using tickets.