Changeset 924 for pykota/trunk/bin/edpykota

Timestamp:

04/16/03 10:22:10 (21 years ago)

Author:

jalet

Message:

More strict error detection.
Minor code rewrite to avoid some repetitive tests.

Files:

• pykota/trunk/bin/edpykota (modified) (7 diffs)

pykota/trunk/bin/edpykota

@@ -23 +23 @@
 #
 # $Log$
+# Revision 1.40  2003/04/16 08:22:09  jalet
+# More strict error detection.
+# Minor code rewrite to avoid some repetitive tests.
+#
 # Revision 1.39  2003/04/16 08:01:53  jalet
 # edpykota --charge command line option works now.
@@ -317 +321 @@
             else :
                 raise PyKotaToolError, _("There's no printer matching %s") % pname
+                
         softlimit = hardlimit = None    
         if options["softlimit"] :
@@ -332 +337 @@
             self.logger.log_message(_("Hard limit %i is less than soft limit %i, values will be exchanged.") % (hardlimit, softlimit))
             (softlimit, hardlimit) = (hardlimit, softlimit)
+            
         if not names :    
             if options["add"] and not printeradded :
@@ -337 +343 @@
             else :    
                 names = [ "*" ] # all users
+                
+        balance = options["balance"]
+        if balance :
+            balance = balance.strip()
+            try :
+                balancevalue = float(balance)
+            except ValueError :    
+                raise PyKotaToolError, _("Invalid balance value %s" % options["balance"])
+            
         if options["charge"] :
             try :
@@ -345 +360 @@
                 if len(charges) < 2 :
                     charges.append(None)
+                    
+        limitby = options["limitby"]
+        if limitby :
+            limitby = limitby.strip().lower()
+        if limitby and (limitby not in ('quota', 'balance')) :    
+            raise PyKotaToolError, _("Invalid limitby value %s" % options["limitby"])
+            
         for (printerid, printer) in printers :
             if options["charge"] :
@@ -416 +438 @@
                             self.storage.deleteUser(ident)
                     else :
-                        limitby = options["limitby"]
-                        if limitby :
-                            limitby = limitby.lower()
-                        if limitby and (limitby not in ('quota', 'balance')) :    
-                            limitby = 'quota'
                         if options["groups"] :
                             if options["noquota"] or options["prototype"] or ((softlimit is not None) and (hardlimit is not None)) :
@@ -436 +453 @@
                             if limitby :
                                 self.storage.limitUserBy(ident, limitby)
-                            balance = options["balance"]    
                             if balance :
-                                balance = balance.strip()
-                                try :
-                                    balancevalue = float(balance)
-                                except ValueError :    
-                                    pass # TODO : log something when incorrect balance value
-                                else :    
-                                    if balance.startswith("+") or balance.startswith("-") :
-                                        self.storage.increaseUserBalance(ident, balancevalue)
-                                    else :
-                                        self.storage.setUserBalance(ident, balancevalue)
+                                if balance.startswith("+") or balance.startswith("-") :
+                                    self.storage.increaseUserBalance(ident, balancevalue)
+                                else :
+                                    self.storage.setUserBalance(ident, balancevalue)
                             self.warnUserPQuota(name, printer)