Changeset 3276 for pykota/trunk/bin/pkprinters

Timestamp:

01/08/08 00:03:01 (16 years ago)

Author:

jerome

Message:

Doesn't drop and regain priviledges anymore : no added security since we could regain them (we needed to regain them for PAM and some end user scripts). This is also more consistent.
Removed SGTERM handling stuff in cupspykota : now only SIGINT can be used.
Now outputs an error message when printing (but doesn't fail) if CUPS is
not v1.3.4 or higher : we need 1.3.4 or higher because it fixes some
problematic charset handling bugs (by only accepting ascii and utf-8,
but this is a different story...)
Now ensures only the supported exit codes are returned by cupspykota :
we used to exit -1 in some cases (see man backend for details).

Files:

• pykota/trunk/bin/pkprinters (modified) (2 diffs)

pykota/trunk/bin/pkprinters

@@ -171 +171 @@
         if uri and (not self.isPrinterCaptured(deviceuri=uri)) :
              newuri = "cupspykota://%s" % uri
-             self.regainPriv() # to avoid having to enter password.
              os.system('lpadmin -p "%s" -v "%s"' % (printer.Name, newuri))
              self.logdebug("Printer %s rerouted to %s" % (printer.Name, newuri))
-             self.dropPriv()
              
     def deroutePrinterFromPyKota(self, printer) :    
@@ -183 +181 @@
              if newuri.startswith("//") :
                  newuri = newuri[2:]
-             self.regainPriv() # to avoid having to enter password.
              os.system('lpadmin -p "%s" -v "%s"' % (printer.Name, newuri))
              self.logdebug("Printer %s rerouted to %s" % (printer.Name, newuri))
-             self.dropPriv()    
                                      
     def main(self, names, options) :