Changeset 1918 for pykota/trunk/pykota/tool.py

Timestamp:

11/15/04 20:59:34 (19 years ago)

Author:

jalet

Message:

PyKota banners now basically work !

Files:

• pykota/trunk/pykota/tool.py (modified) (3 diffs)

pykota/trunk/pykota/tool.py

@@ -22 +22 @@
 #
 # $Log$
+# Revision 1.140  2004/11/15 19:59:34  jalet
+# PyKota banners now basically work !
+#
 # Revision 1.139  2004/11/15 15:54:03  jalet
 # Continued integration of Matt's patch for banners
@@ -1221 +1224 @@
            by the printer.
         """
-        banner = "" # no banner by default
         if bannerfileorcommand :
+            banner = "" # no banner by default
             if (os.access(bannerfileorcommand, os.X_OK)) :
                 self.logdebug("Launching %s to generate a banner." % bannerfileorcommand)
                 child = popen2.Popen3(bannerfileorcommand, capturestderr=1)
+                banner = child.fromchild.read()
                 child.tochild.close()
                 child.childerr.close()
-                banner = child.fromchild.read()
                 child.fromchild.close()
                 status = child.wait()
@@ -1243 +1246 @@
                     banner = fh.read()
                     fh.close()
-        return cStringIO.StringIO(banner)
+            if banner :        
+                return cStringIO.StringIO(banner)
     
     def startingBanner(self, printername) :