Changeset 956

Timestamp:

04/24/03 13:53:48 (21 years ago)

Author:

jalet

Message:

Default policy for unknown users/groups is to DENY printing instead
of the previous default to ALLOW printing. This is to solve an accuracy
problem. If you set the policy to ALLOW, jobs printed by in nexistant user
(from PyKota's POV) will be charged to the next user who prints on the
same printer.

Location:

pykota/trunk

Files:

• bin/pykota (modified) (2 diffs)
• conf/pykota.conf.sample (modified) (1 diff)
• NEWS (modified) (1 diff)
• pykota/config.py (modified) (2 diffs)
• pykota/tool.py (modified) (5 diffs)
• pykota/version.py (modified) (1 diff)

pykota/trunk/bin/pykota

@@ -23 +23 @@
 #
 # $Log$
+# Revision 1.25  2003/04/24 11:53:48  jalet
+# Default policy for unknown users/groups is to DENY printing instead
+# of the previous default to ALLOW printing. This is to solve an accuracy
+# problem. If you set the policy to ALLOW, jobs printed by in nexistant user
+# (from PyKota's POV) will be charged to the next user who prints on the
+# same printer.
+#
 # Revision 1.24  2003/04/23 22:13:56  jalet
 # Preliminary support for LPRng added BUT STILL UNTESTED.
@@ -196 +203 @@
             # log a message in any case.
             policy = kotafilter.config.getPrinterPolicy(kotafilter.printername)
-            if policy in [None, "ALLOW"] :
+            if policy == "ALLOW" :
                 action = "POLICY_ALLOW"
             else :    

pykota/trunk/conf/pykota.conf.sample

@@ -117 +117 @@
 # This value can be set either globally or per printer or both.
 # If both are defined, the printer option has priority.
-# If the value is not set then the default policy ALLOW applies.
-policy: allow
+# If the value is not set then the default policy DENY applies.
+# ATTENTION :
+#     Before 1.04pre4 the default value was ALLOW, but unknown users
+#     allowed to print causes accuracy problems : their jobs are
+#     charged to the next person who prints on the same printer.
+policy: deny
 

pykota/trunk/NEWS

@@ -22 +22 @@
 PyKota NEWS :
 
+    - 1.04pre4 :
+    
+        - Default print policy for users/groups unknown from 
+          the print quota system is now DENY instead of ALLOW,
+          since ALLOW can generate inaccurate results
+          (incorrect job sizes charged to the wrong persons)
+          
     - 1.04pre3 :
     

pykota/trunk/pykota/config.py

@@ -21 +21 @@
 #
 # $Log$
+# Revision 1.23  2003/04/24 11:53:48  jalet
+# Default policy for unknown users/groups is to DENY printing instead
+# of the previous default to ALLOW printing. This is to solve an accuracy
+# problem. If you set the policy to ALLOW, jobs printed by in nexistant user
+# (from PyKota's POV) will be charged to the next user who prints on the
+# same printer.
+#
 # Revision 1.22  2003/04/23 22:13:57  jalet
 # Preliminary support for LPRng added BUT STILL UNTESTED.
@@ -213 +220 @@
             policy = self.getPrinterOption(printer, "policy").upper()
         except PyKotaConfigError :    
-            policy = "ALLOW"
+            policy = "DENY"
         if policy not in validpolicies :
             raise PyKotaConfigError, _("Option policy in section %s only supports values in %s") % (printer, str(validpolicies))

pykota/trunk/pykota/tool.py

@@ -21 +21 @@
 #
 # $Log$
+# Revision 1.38  2003/04/24 11:53:48  jalet
+# Default policy for unknown users/groups is to DENY printing instead
+# of the previous default to ALLOW printing. This is to solve an accuracy
+# problem. If you set the policy to ALLOW, jobs printed by in nexistant user
+# (from PyKota's POV) will be charged to the next user who prints on the
+# same printer.
+#
 # Revision 1.37  2003/04/24 08:08:27  jalet
 # Debug message forgotten
@@ -352 +359 @@
             balance = self.storage.getGroupBalance(groupid)
             if balance is None :
-                if policy in [None, "ALLOW"] :
+                if policy == "ALLOW" :
                     action = "POLICY_ALLOW"
                 else :    
@@ -368 +375 @@
             if quota is None :
                 # Unknown group or printer or combination
-                if policy in [None, "ALLOW"] :
+                if policy == "ALLOW" :
                     action = "POLICY_ALLOW"
                 else :    
@@ -427 +434 @@
             balance = self.storage.getUserBalance(userid)
             if balance is None :
-                if policy in [None, "ALLOW"] :
+                if policy == "ALLOW" :
                     action = "POLICY_ALLOW"
                 else :    
@@ -443 +450 @@
             if quota is None :
                 # Unknown user or printer or combination
-                if policy in [None, "ALLOW"] :
+                if policy == "ALLOW" :
                     action = "POLICY_ALLOW"
                 else :    

pykota/trunk/pykota/version.py

@@ -21 +21 @@
 #
 
-__version__ = "1.04pre3-unofficial"
+__version__ = "1.04pre4-unofficial"
 
 __doc__ = """PyKota : a complete Printing Quota Solution for CUPS and LPRng."""