Changeset 3542

Timestamp:

04/27/10 10:06:19 (14 years ago)

Author:

jerome

Message:

It mostly works now with a real Cartadis TCRS (Serial #68169). Time to
put some additional credits onto my card, otherwise I won't be able to
test for long :-)
TODO : improve robustness, and implement the few missing calls.

Files:

• pykocard/trunk/pykocard/cartadistcrs.py (modified) (8 diffs)

pykocard/trunk/pykocard/cartadistcrs.py

@@ -51 +51 @@
 ERRADMINNOTALLOWED = -11
 
+# Sensor
+SENSORNOCARD=0     # No card present
+SENSORUNKNOWN1=1   # Partially inside the TCRS
+SENSORCARDINSIDE=2 # Card is inside the TCRS
+SENSORUNKNOWN3=3   # Partially inside the TCRS
 
 class CartadisTCRS :
@@ -59 +64 @@
        Cartadis is a registered trademark from Copie Monnaie France (C.M.F.)
     """
-    def __init__(self, device, timeout=5.0, debug=False) :
+    def __init__(self, device, timeout=1.0, debug=False) :
         """Initializes the connection to the TCRS."""
         self.device = device
@@ -90 +95 @@
                                   timeout=timeout)
 
-        # cleans up any data waiting to be read
+        # cleans up any data waiting to be read or written
         try :
             self.tcrs.flushInput()
+            self.tcrs.flushOutput()
+            self.tcrs.read(1) # Skips the first $ prompt
         except serial.serialutil.SerialException, msg :
             self.logError(msg)
@@ -100 +107 @@
             self.versionNumber = self.version()
             self.serialNumber = self.serial()
-            self.logDebug("%s terminal detected on device %s with serial number %s" \
+            self.logDebug("%s TCRS detected on device %s with serial number %s" \
                               % (self.versionNumber,
                                  self.device,
                                  self.serialNumber))
-            self.supportedCommands = self.help()
-            self.logDebug("Supported commands : %s" % self.supportedCommands)
 
     def __del__(self) :
@@ -147 +152 @@
             answer = self.tcrs.readline(eol=self.prompt)
             self.logDebug("TCRS answered %s" % repr(answer))
+            if answer.startswith(command) :
+                answer = answer[len(command):]
             if answer.startswith(self.sol) and answer.endswith(self.prompt) :
                 return answer[self.sollen:-self.promptlen]
             else :
-                self.logError("Unknown answer %s" % repr(answer))
+                if answer != self.sol :
+                    self.logError("Unknown answer %s" % repr(answer))
                 return None
         else :
@@ -169 +177 @@
     def read(self) :
         """Reads the card's content to the TCRS. Returns the type of card or an error value."""
-        return int(self.sendCommand("read"))
+        return int(self.sendCommand("read") or -1)
 
     def write(self) :
@@ -192 +200 @@
             return int(self.sendCommand("value"))
         else :
-            return self.sendCommand("value", value)
-
-    def account(self, account) :
+            return self.sendCommand("value", str(value))
+
+    def account(self, account=None) :
         """Returns the last account number read, or sets the account number, but doesn't write it to the card yet.'"""
         if account is None :
             return int(self.sendCommand("account"))
         else :
-            return self.sendCommand("account", account)
-
-    def department(self, department) :
+            return self.sendCommand("account", str(account))
+
+    def department(self, department=None) :
         """Returns the last department number read, or sets the department number, but doesn't write it to the card yet.'"""
         if department is None :
             return int(self.sendCommand("department"))
         else :
-            return self.sendCommand("department", department)
-
-    def group(self, group) :
+            return self.sendCommand("department", str(department))
+
+    def group(self, group=None) :
         """Returns the last group number read, or sets the group number, but doesn't write it to the card yet.'"""
         if group is None :
             return int(self.sendCommand("group"))
         else :
-            return self.sendCommand("group", group)
+            return self.sendCommand("group", str(group))
 
     def addgrp(self, group=None) :
         """Adds the group to the list of allowed ones. If no group, the one on the admin card is used."""
-        return int(self.sendCommand("addgrp", group))
+        return int(self.sendCommand("addgrp", str(group)))
 
     def listgrp(self) :
         """Returns the list of allowed group numbers."""
-        return self.sendCommand("listgrp")
+        return [int(g) for g in self.sendCommand("listgrp").split()]
 
     def delgrp(self, group) :
         """Deletes the group from the list of allowed groups."""
-        return int(self.sendCommand("delgrp", group))
-
-    def cardtype(self, cardtype) :
+        return int(self.sendCommand("delgrp", str(group)))
+
+    def cardtype(self, cardtype=None) :
         """Returns the type of card, or sets it (not clear in the doc if a write call is needed or not)."""
-        return int(self.sendCommand("cardtype", cardtype))
+        # TODO : doesn't seem to return a meaningful answer
+        if cardtype is None :
+            answer = self.sendCommand("cardtype")
+        else :
+            answer = self.sendCommand("cardtype", str(cardtype))
+        try :
+            return int(answer)
+        except ValueError :
+            self.logError("Unknown card type %s" % repr(answer))
+            return None
 
     def display(self, text) :
@@ -265 +282 @@
 if __name__ == "__main__" :
     # Minimal testing
-    tcrs = CartadisTCRS("/dev/ttyS0", debug=True)
-    tcrs.help()
-    tcrs.close()
+    tcrs = CartadisTCRS("/dev/ttyS0", debug=False)
+    try :
+        sys.stdout.write("%s TCRS detected on device %s with serial number %s\n" \
+                              % (tcrs.versionNumber,
+                                 tcrs.device,
+                                 tcrs.serialNumber))
+
+
+        sys.stdout.write("This Cartadis TCRS supports the following commands :\n%s\n" % tcrs.help())
+        sys.stdout.write("Allowed groups : %s\n" % tcrs.listgrp())
+
+        import time
+        sys.stdout.write("Please insert your card into the TCRS...")
+        sys.stdout.flush()
+        while True :
+            cardpresent = tcrs.sensor()
+            tcrs.logDebug("Sensor Status : %i\n" % cardpresent)
+            if cardpresent == SENSORCARDINSIDE :
+                break
+            time.sleep(1.0)
+        sys.stdout.write("\n")
+
+        sys.stdout.write("Card read status : %s\n" % tcrs.read())
+        sys.stdout.write("Group : %s\n" % tcrs.group())
+        value = tcrs.value()
+        tcrs.display("Card has %s credits" % value)
+        sys.stdout.write("Card has %s credits\n" % value)
+        sys.stdout.write("Department : %s\n" % tcrs.department())
+        sys.stdout.write("Account : %s\n" % tcrs.account())
+        sys.stdout.write("Transaction # : %s\n" % tcrs.trnum())
+        #
+        # This block commented out because I don't have many credits for testing ;-)
+        # It seems to work anyway.
+        # Now we decrement the number of credits
+        #tcrs.value(value-1)
+        # And we flush the card's content to the card
+        #sys.stdout.write("Card write status : %s\n" % tcrs.write())
+        # Now we read it back
+        #tcrs.read()
+        #sys.stdout.write("Card now has %s credits\n" % tcrs.value())
+    finally :
+        # We always do an eject, even if card not present
+        tcrs.eject()
+        tcrs.close()