Changeset 2830 for pykota/trunk/pykota/storages

Timestamp:

04/04/06 11:40:56 (18 years ago)

Author:

jerome

Message:

Improved the code's quality a bit with pylint.

Location:

pykota/trunk/pykota/storages

Files:

• ldapstorage.py (modified) (4 diffs)
• mysqlstorage.py (modified) (1 diff)
• pgstorage.py (modified) (1 diff)
• sqlitestorage.py (modified) (1 diff)
• sql.py (modified) (1 diff)

pykota/trunk/pykota/storages/ldapstorage.py

@@ -30 +30 @@
 
 import sys
-import os
 import types
 import time
@@ -39 +38 @@
 from mx import DateTime
 
-from pykota.storage import PyKotaStorageError, BaseStorage, StorageObject, \
+from pykota.storage import PyKotaStorageError, BaseStorage, \
                            StorageUser, StorageGroup, StoragePrinter, \
                            StorageJob, StorageLastJob, StorageUserPQuota, \
@@ -827 +826 @@
         names = [self.userCharsetToDatabase(n) for n in names]
         if self.info["userquotabase"].lower() == "user" :
-           base = self.info["userbase"]
+            base = self.info["userbase"]
         else :
-           base = self.info["userquotabase"]
+            base = self.info["userquotabase"]
         result = self.doSearch("(&(objectClass=pykotaUserPQuota)(pykotaPrinterName=%s)(|%s))" % \
                                   (pname, "".join(["(pykotaUserName=%s)" % uname for uname in names])), \
@@ -872 +871 @@
         names = [self.userCharsetToDatabase(n) for n in names]
         if self.info["groupquotabase"].lower() == "group" :
-           base = self.info["groupbase"]
+            base = self.info["groupbase"]
         else :
-           base = self.info["groupquotabase"]
+            base = self.info["groupquotabase"]
         result = self.doSearch("(&(objectClass=pykotaGroupPQuota)(pykotaPrinterName=%s)(|%s))" % \
                                   (pname, "".join(["(pykotaGroupName=%s)" % gname for gname in names])), \

pykota/trunk/pykota/storages/mysqlstorage.py

@@ -26 +26 @@
 import time
 
-from pykota.storage import PyKotaStorageError,BaseStorage,StorageObject,StorageUser,StorageGroup,StoragePrinter,StorageJob,StorageLastJob,StorageUserPQuota,StorageGroupPQuota
+from pykota.storage import PyKotaStorageError, BaseStorage
 from pykota.storages.sql import SQLStorage
 

pykota/trunk/pykota/storages/pgstorage.py

@@ -26 +26 @@
 from types import StringType
 
-from pykota.storage import PyKotaStorageError,BaseStorage,StorageObject,StorageUser,StorageGroup,StoragePrinter,StorageJob,StorageLastJob,StorageUserPQuota,StorageGroupPQuota
+from pykota.storage import PyKotaStorageError, BaseStorage
 from pykota.storages.sql import SQLStorage
 

pykota/trunk/pykota/storages/sqlitestorage.py

@@ -25 +25 @@
 import time
 
-from pykota.storage import PyKotaStorageError,BaseStorage,StorageObject,StorageUser,StorageGroup,StoragePrinter,StorageJob,StorageLastJob,StorageUserPQuota,StorageGroupPQuota
+from pykota.storage import PyKotaStorageError, BaseStorage
 from pykota.storages.sql import SQLStorage
 

pykota/trunk/pykota/storages/sql.py

@@ -23 +23 @@
 #
 
-from pykota.storage import PyKotaStorageError, BaseStorage, StorageObject, \
-                           StorageUser, StorageGroup, StoragePrinter, \
+from pykota.storage import StorageUser, StorageGroup, StoragePrinter, \
                            StorageJob, StorageLastJob, StorageUserPQuota, \
                            StorageGroupPQuota, StorageBillingCode