Changeset 2677

Timestamp:

02/12/06 00:15:49 (18 years ago)

Author:

jerome

Message:

Ensures that pkbcodes doesn't enter the modification loop if there's nothing to modify.

Location:

pykota/trunk

Files:

• bin/pkbcodes (modified) (1 diff)
• NEWS (modified) (1 diff)

pykota/trunk/bin/pkbcodes

@@ -130 +130 @@
                 self.display("%s...\n" % _("Modification"))
                 
-            nbtotal = len(billingcodes)            
-            for i in range(nbtotal) :        
-                billingcode = billingcodes[i]
-                if options["list"] :    
-                    print "%s [%s] %s %s %s %.2f %s" % \
-                          (billingcode.BillingCode, billingcode.Description, \
-                           billingcode.PageCounter, \
-                           _("pages"), \
-                           _("and"), \
-                           billingcode.Balance, \
-                           _("credits"))
-                else :    
-                    if options["reset"] :
-                        billingcode.reset()    
-                    if options["description"] is not None :
-                        billingcode.setDescription(options["description"].strip())
-                    billingcode.save()    
-                    percent = 100.0 * float(i) / float(nbtotal)
-                    self.display("\r%.02f%%" % percent)
+            if (not options["add"]) \
+                or options["description"] or options["reset"] : # optimize when nothing to do
+                nbtotal = len(billingcodes)            
+                for i in range(nbtotal) :        
+                    billingcode = billingcodes[i]
+                    if options["list"] :    
+                        print "%s [%s] %s %s %s %.2f %s" % \
+                              (billingcode.BillingCode, billingcode.Description, \
+                               billingcode.PageCounter, \
+                               _("pages"), \
+                               _("and"), \
+                               billingcode.Balance, \
+                               _("credits"))
+                    else :    
+                        if options["reset"] :
+                            billingcode.reset()    
+                        if options["description"] is not None :
+                            billingcode.setDescription(options["description"].strip())
+                        billingcode.save()    
+                        percent = 100.0 * float(i) / float(nbtotal)
+                        self.display("\r%.02f%%" % percent)
                         
         if not options["list"] :                

pykota/trunk/NEWS

@@ -24 +24 @@
     - 1.24alpha11 :
     
+        - Huge speed improvements when modifying billing codes.
+        
         - Both pkbcodes and pkprinters now display the percent done
           for all actions.