Changeset 2588

Timestamp:

11/24/05 15:14:53 (18 years ago)

Author:

jerome

Message:

Now regain priviledges before running an external mailto directive,
because smbstatus can't be run setuid (smbstatus is used by mailandpopup.sh)

Location:

pykota/trunk

Files:

• bin/cupspykota (modified) (1 diff)
• bin/mailandpopup.sh (modified) (1 diff)
• NEWS (modified) (1 diff)
• pykota/version.py (modified) (1 diff)

pykota/trunk/bin/cupspykota

@@ -804 +804 @@
             if mailto == "EXTERNAL" :
                 # TODO : clean this again
+                self.regainPriv()
                 self.externalMailTo(arguments, self.Action, self.User, self.Printer, self.Reason)
+                self.dropPriv()
             else :    
                 # TODO : clean this again

pykota/trunk/bin/mailandpopup.sh

@@ -42 +42 @@
 # we must also supply the IP address. This will use smbstatus to get all IPs
 # where the user is logged in and send the message there:
-IPS=`smbstatus -b -u $UNAME | grep '(' | cut -d'(' -f 2 | cut -d')' -f 1`
-for i in $IPS; do
-    echo $UTF8MESSAGE | smbclient -M "$UNAME" -I $i 2>&1 >/dev/null;
+IPS=`smbstatus -b -u "$UNAME" | grep "$UNAME" | cut -d '(' -f 2,2 | cut -d ')' -f 1,1`
+for i in $IPS ; do
+    echo "$UTF8MESSAGE" | smbclient -M "$UNAME" -I $i 2>&1 ;
 done

pykota/trunk/NEWS

@@ -22 +22 @@
 PyKota NEWS :
        
+    - 1.24alpha3 :
+    
+        - Fix for mailandpopup.sh : smbstatus can't be run setuid, 
+          so we regain priviledges before running an external 
+          mailto directive.
+        
     - 1.24alpha2 :
     

pykota/trunk/pykota/version.py

@@ -22 +22 @@
 #
 
-__version__ = "1.24alpha2_unofficial"
+__version__ = "1.24alpha3_unofficial"
 
 __doc__ = "PyKota : a complete Printing Quota Solution for CUPS."